Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more comments to the CONTRIBUTING.md document #18469

Merged
merged 2 commits into from Jan 30, 2022

Conversation

zeripath
Copy link
Contributor

  • Explain how to title your Backport PR
  • Advise that the first comment in a PR should explain the PR
  • Include information about BREAKING changes
  • Include information about backports/frontports
  • Add reference command for creating backports
  • Add reference commandline for creating large characters
  • Add information about updating docs/config.yaml
  • Update year in the copyright

Signed-off-by: Andrew Thornton art27@cantab.net

* Explain how to title your Backport PR
* Advise that the first comment in a PR should explain the PR
* Include information about BREAKING changes
* Include information about backports/frontports
* Add reference command for creating backports
* Add reference commandline for creating large characters
* Add information about updating docs/config.yaml
* Update year in the copyright

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/docs This PR mainly updates/creates documentation label Jan 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 30, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2022
@6543
Copy link
Member

6543 commented Jan 30, 2022

🚀

@6543 6543 merged commit 342c691 into go-gitea:main Jan 30, 2022
@zeripath zeripath deleted the more-CONTRIBUTING-tips branch January 30, 2022 19:11
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Explain how to title your Backport PR
* Advise that the first comment in a PR should explain the PR
* Include information about BREAKING changes
* Include information about backports/frontports
* Add reference command for creating backports
* Add reference commandline for creating large characters
* Add information about updating docs/config.yaml
* Update year in the copyright

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants