Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With "external issue tracker" setting enabled, clicking the "Pull Requests", "New file", "Upload file", "Edit file" links returns 404 #1847

Closed
2 of 7 tasks
wyattoday opened this issue May 31, 2017 · 0 comments · Fixed by #1852
Labels
Milestone

Comments

@wyattoday
Copy link

wyattoday commented May 31, 2017

In any repository, click Settings, and then choose "Use external issue tracker", and set the external URL. Click "Update Settings". Now, when you visit the "Pull Requests" link you'll get an error 404.

I looked in our log and got this error:

2017/05/31 15:57:39 [...ules/context/repo.go:525 func1()] [E] CheckUnit: You are not allowed to visit this repository unit: 2

Creating a row in our database in the "repo_unit" table with type "2" and index "2" with a "{}" config fixed it for us. So, something in the "Update Settings" code is not correctly saving the Pull Request permissions for the repository.

The side-effect to making that change directly in the database, though, is that now there are 2 "Issues" tabs.

Update (6/2/2017):

There is also a 404 error when clicking "New file" and "Upload file" using the above repository settings. The workaround fixes the 404 there as well.

So, to recap, with the settings set like above (external issue tracker), the following things fail with a 404 error:

  • Clicking "Pull request" tab link
  • Clicking the "New file" blue link
  • Clicking the "Upload file" blue link
  • Clicking the "Edit file" "pencil" link on any file.
@lunny lunny added the type/bug label Jun 1, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 1, 2017
@wyattoday wyattoday changed the title With "external issue tracker" setting enabled, clicking the "Pull Requests" link returns 404 With "external issue tracker" setting enabled, clicking the "Pull Requests", "New file", "Upload file" links returns 404 Jun 2, 2017
@wyattoday wyattoday changed the title With "external issue tracker" setting enabled, clicking the "Pull Requests", "New file", "Upload file" links returns 404 With "external issue tracker" setting enabled, clicking the "Pull Requests", "New file", "Upload file", "Edit file" links returns 404 Jun 2, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants