Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns on "New Repository" screen #18565

Open
fnetX opened this issue Feb 2, 2022 · 3 comments
Open

Dropdowns on "New Repository" screen #18565

fnetX opened this issue Feb 2, 2022 · 3 comments
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@fnetX
Copy link
Contributor

fnetX commented Feb 2, 2022

Gitea Version

1.17.0+dev-88-g1f0fea7e4

Operating System

Debian GNU/Linux 11

Browser Version

Firefox 96.0.3

Can you reproduce the bug on the Gitea demo site?

Yes

Description

While working on #18564, I noticed that the "New Repository" screen might do well with some dropdown icons added where there is a dropdown, to avoid confusion. The "Signature Trust Model" already shows a dropdown icon, so it would add some consistency.

Further, I noticed that clicking into some boxes does only open the dropdown for the text width, clicking next to the grey text does nothing for the

  • license
  • issue
  • template

Dropdowns, but works well for e.g. the gitignore and README dropdowns.

I just wanted to make sure this is tracked.

Screenshots

image

@silverwind
Copy link
Member

I think this is because they are not real dropdowns, but text fields which spawn a dropdown on focus. Fields "Owner" and "Signature Trust Model" are real dropdowns and we should adjust the other fields to be the same.

@fnetX
Copy link
Contributor Author

fnetX commented Feb 3, 2022

adjust the other fields to be the same.

be the same or look the same? Maybe I can add more dropdown icons, not sure if I can fix the click area so the whole box triggers something (I hope so), if you intend some refactoring here, I don't fully understand what you mean - but I'm not really a frontend guy.

@silverwind
Copy link
Member

silverwind commented Feb 3, 2022

I think the root issue is we are dealing with two different elements with different functionality.

  1. Text fields with "autocomplete" style dropdown. Generally, I think triangle does not make sense on it.
  2. Actual dropdowns that don't allow text inputs. Triangle mandatory for UX.

I think the ideal solution would be an element that combines the two, e.g. act like a dropdown, with a search field to filter, like this one:

https://blueprintjs.com/docs/#select/select-component

image

Thought, I'm rather certain this may be impossible to do with what fomantic provides.

@denyskon denyskon added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants