Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design Changes] Make the mobile layout more compact #18589

Closed
schorsch13 opened this issue Feb 4, 2022 · 3 comments
Closed

[Design Changes] Make the mobile layout more compact #18589

schorsch13 opened this issue Feb 4, 2022 · 3 comments
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@schorsch13
Copy link
Contributor

Introduction

In the mobile view there is a lot of spacing and padding in the directory list of a repo.

image

Proposal

FiliusPatris tried to inspect the directory list with the firefox devtools and was able to remove the unnecessary spacing with the following css:

.name {
	display: table-cell;
	max-width: 20%;
}

.message {
	display: table-cell;
	width: 100%;
}

.age {
	display: none;
}

Credits

The main idea and the proposed css changes come from the codeberg user FiliusPatris. For further information have a look at the issue on codeberg: https://codeberg.org/Codeberg/Community/issues/190

@n194
Copy link
Contributor

n194 commented Feb 4, 2022

#15005 fixes this, but that PR has stalled.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 4, 2022
@silverwind
Copy link
Member

silverwind commented Feb 4, 2022

display: table-cell is kind of a legacy CSS value that forces table layout which is its own can of worms. I suggest display: flex or display: grid with appropriate media queries.

Any yes, the current design is desktop-first, I doubt anyone really gave much thought to a proper mobile layout which can only be achieved with carefully placed media queries.

@wxiaoguang
Copy link
Contributor

It should have been improved by

Great thanks to @Gusted

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

5 participants