Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the details links of commit-statuses in headers #18661

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 7, 2022

Although #18538 fixes the size of the header block the details links are still
coalescing.

Here we simply display: flex these instead of using .right

Fix #18498

Signed-off-by: Andrew Thornton art27@cantab.net

Although go-gitea#18538 fixes the size of the header block the details links are still
coalescing.

Here we simply display: flex these instead of using .right

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.16 labels Feb 7, 2022
@zeripath zeripath added this to the 1.17.0 milestone Feb 7, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ae0d8d9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18661   +/-   ##
=======================================
  Coverage        ?   46.66%           
=======================================
  Files           ?      846           
  Lines           ?   121364           
  Branches        ?        0           
=======================================
  Hits            ?    56631           
  Misses          ?    57853           
  Partials        ?     6880           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0d8d9...2dc6a4b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2022
@wxiaoguang wxiaoguang merged commit c86ecae into go-gitea:main Feb 11, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 11, 2022
@wxiaoguang
Copy link
Contributor

We can have a backport now ~

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 11, 2022
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 11, 2022
@zeripath zeripath deleted the fix-18498-part-2-separate-details-links branch February 12, 2022 06:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 12, 2022
* giteaofficial/main:
  Send mail to issue/pr assignee/reviewer also when OnMention is set (go-gitea#18707)
  Reduce CI go module downloads, add make targets (go-gitea#18708)
  Add number in queue status to monitor page (go-gitea#18712)
  Fix source code line highlighting (go-gitea#18729)
  Fix forked repositories missed tags (go-gitea#18719)
  [skip ci] Updated translations via Crowdin
  Fix release typo (go-gitea#18728)
  Display template path of current page in dev mode (go-gitea#18717)
  Separate the details links of commit-statuses in headers (go-gitea#18661)
  Add LDAP group sync to Teams, fixes go-gitea#1395 (go-gitea#16299)
  Change git.cmd to RunWithContext (go-gitea#18693)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit status list squished on commit view
5 participants