Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo #18713

Merged

Conversation

zeripath
Copy link
Contributor

Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.

Fix #18706

Signed-off-by: Andrew Thornton art27@cantab.net

Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.

Fix go-gitea#18706

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2022
@zeripath
Copy link
Contributor Author

Make lgtm work

@zeripath zeripath merged commit 393ea86 into go-gitea:main Feb 11, 2022
@zeripath zeripath deleted the fix-18706-prevent-NPE-in-pull-requests branch February 11, 2022 08:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 11, 2022
* giteaofficial/main:
  Always set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo (go-gitea#18713)
@lunny
Copy link
Member

lunny commented Feb 11, 2022

Please send backport

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 12, 2022
…o-gitea#18713)

Backport go-gitea#18713

Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.

Fix go-gitea#18706

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 12, 2022
zeripath added a commit that referenced this pull request Feb 12, 2022
…18713) (#18737)

Backport #18713

Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.

Fix #18706

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…o-gitea#18713)

Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.

Fix go-gitea#18706

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template Rendering Error When Viewing Pull-Requests
4 participants