Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeforeSourcePath should point to base commit #18799

Merged
merged 4 commits into from
Feb 25, 2022
Merged

BeforeSourcePath should point to base commit #18799

merged 4 commits into from
Feb 25, 2022

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Feb 17, 2022

Clicking "View File" on a deleted file gives a 404 because the link points to head commit instead of base commit.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 24, 2022 •
edited
Loading

That's a regression of #17551 and the cause of #18861.

fixes #18861

@KN4CK3R KN4CK3R mentioned this pull request Feb 24, 2022
Closed
@lunny lunny added type/bug backport/v1.16 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 24, 2022
silverwind
silverwind approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it fixes #18861.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2022
@lunny
Copy link
Member

lunny commented Feb 24, 2022

Please send backport

@jpraet jpraet mentioned this pull request Feb 24, 2022
Merged
@lunny
Copy link
Member

lunny commented Feb 25, 2022

make L-G-T-M work

@lunny lunny merged commit e4ef61e into go-gitea:main Feb 25, 2022
@lunny lunny added the backport/done All backports for this PR have been created label Feb 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c697b51 
* giteaofficial/main:
  BeforeSourcePath should point to base commit (go-gitea#18799)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@jpraet @lunny
BeforeSourcePath should point to base commit (go-gitea#18799)
fdab87e 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Mar 29, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@silverwind silverwind silverwind approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jpraet @KN4CK3R @lunny @silverwind @delvh @wxiaoguang @GiteaBot