Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run 'make release' on PRs #1908

Merged
merged 1 commit into from Jun 9, 2017
Merged

Don't run 'make release' on PRs #1908

merged 1 commit into from Jun 9, 2017

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Jun 8, 2017

Don't run make release on PRs. Takes 20-25 minutes to run (90% of total time) on drone-servers... Make-shift solution until we bring up more drone-agents...

The only thing this does is disabling build-tests on all architectures excluding amd64

@bkcsoft bkcsoft added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 8, 2017
@appleboy
Copy link
Member

appleboy commented Jun 8, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 8, 2017
@tboerger
Copy link
Member

tboerger commented Jun 8, 2017

We had disabled that in the past, until some architectures failed on master. That's why we always enabled it

@appleboy
Copy link
Member

appleboy commented Jun 8, 2017

@bkcsoft @tboerger What time do we start to upgrade Drone to 0.7.x version?

@sapk
Copy link
Member

sapk commented Jun 8, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 8, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 9, 2017
@lunny lunny merged commit 4a3f404 into master Jun 9, 2017
@bkcsoft
Copy link
Member Author

bkcsoft commented Jun 10, 2017

@tboerger right, but running make release takes a shit-ton of time 😞

@appleboy appleboy deleted the bkcsoft/no-static-pr branch June 10, 2017 00:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants