Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contrib/upgrade.sh #19222

Merged
merged 7 commits into from Mar 27, 2022
Merged

Fix contrib/upgrade.sh #19222

merged 7 commits into from Mar 27, 2022

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 26, 2022

See commit messages.

..yes, it still passes shellcheck ;)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2022
@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 27, 2022
@zeripath zeripath added this to the 1.17.0 milestone Mar 27, 2022
@zeripath zeripath merged commit 42fe076 into go-gitea:main Mar 27, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* fix idempotency of script (eg when aborting the downloads)
* improve readability (user facing variables first, definitions next, statements last)
* improve dependency checks
* fix ignored $giteaversion variable
* more logging
* print usage string on incorrect usage
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants