When dumping trim the standard suffices instead of a random suffix #19440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate through the supported suffices and trim those. Fix go-gitea#19424 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
This is a change from the mechanism proposed in #18000 Instead of trimming the last extension no matter what it is - we just trim off the first of our known suffices before adding the correct type back on. |
GiteaBot
added
the
lgtm/need 2
Gusted
approved these changes
Apr 20, 2022
GiteaBot
added
lgtm/need 1
6543
approved these changes
Apr 20, 2022
GiteaBot
added
lgtm/done
jolheiser
approved these changes
Apr 20, 2022
|
Maybe there should be more fixes for #18000
|
|
And |
|
@wxiaoguang changed |
wxiaoguang
approved these changes
Apr 20, 2022
|
please backport |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Apr 20, 2022
…o-gitea#19440) * When dumping trim the standard suffices instead of a random suffix Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate through the supported suffices and trim those. Fix go-gitea#19424 Signed-off-by: Andrew Thornton <art27@cantab.net> * fix enum with to have correct supported types only Co-authored-by: 6543 <6543@obermui.de>
|
-> #19447 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 20, 2022
* giteaofficial/main: When dumping trim the standard suffices instead of a random suffix (go-gitea#19440) Add uploadpack.allowAnySHA1InWant to allow --filter=blob:none with older git clients (go-gitea#19430) Don't allow merging PR's which are being conflict checked (go-gitea#19357) doc: add brief intro on using traefik as reverse-proxy (go-gitea#19432) Fix panic in team repos API (go-gitea#19431) When updating mirror repo intervals by API reschedule next update too (go-gitea#19429) Fix nil error when some pages are rendered outside request context (go-gitea#19427) Add Helm Chart registry (go-gitea#19406)
zeripath
added a commit
that referenced
this pull request
Apr 20, 2022
…19440) (#19447) * When dumping trim the standard suffices instead of a random suffix Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate through the supported suffices and trim those. Fix #19424 Signed-off-by: Andrew Thornton <art27@cantab.net> * fix enum with to have correct supported types only Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: zeripath <art27@cantab.net>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…o-gitea#19440) * When dumping trim the standard suffices instead of a random suffix Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate through the supported suffices and trim those. Fix go-gitea#19424 Signed-off-by: Andrew Thornton <art27@cantab.net> * fix enum with to have correct supported types only Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
path.Ext()to trim the last "extension" suffix, just iteratethrough the supported suffices and trim those.
Fix #19424
Signed-off-by: Andrew Thornton art27@cantab.net