Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse the Review button when a comment is added to a review #19611

Closed
jtran opened this issue May 4, 2022 · 0 comments · Fixed by #19612
Closed

Pulse the Review button when a comment is added to a review #19611

jtran opened this issue May 4, 2022 · 0 comments · Fixed by #19612
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@jtran
Copy link
Contributor

jtran commented May 4, 2022

Feature Description

As a new user unfamiliar with pull request reviews, I would like the Review button to have a visual indicator (like a pulse) each time a comment is added to a review. The problem this helps deal with is teaching new users that when a comment is added to a review, it is not shown to any other users until the review is submitted.

As far as I know, there's currently very little (nothing?) that helps teach users about this concept. Users are expected to just know how it works. I think that some kind of visual indicator when a comment is added to a review would help communicate that further action of submitting the review is required. Something like a pulse is nice because it doesn't require that users read, which few people do.

GitHub's interface both pulses the review button and increments a counter of the number of pending comments in the button's text. I think the counter is nice, but the pulse is a prerequisite since new users may not know to look for the counter.

Screenshots

pusle-review3.mov
@jtran jtran added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels May 4, 2022
@lunny lunny added this to the 1.17.0 milestone May 7, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants