Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplicated Docker filesystem layers in package-registry #19624

Merged
merged 1 commit into from
May 5, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 5, 2022

A Docker manifest may contain multiple filesystem layers with the same hash. This PR skips the duplicated layers.

@KN4CK3R KN4CK3R added this to the 1.17.0 milestone May 5, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2022
@zeripath zeripath merged commit 4691e59 into go-gitea:main May 5, 2022
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 5, 2022
@zeripath zeripath changed the title Skip duplicated Docker filesystem layers Skip duplicated Docker filesystem layers in package-registry May 5, 2022
@KN4CK3R KN4CK3R deleted the fix-container-duplicate-layer branch May 6, 2022 05:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2022
* giteaofficial/main:
  Simplify `IsVendor` (go-gitea#19626)
  Prevent NPE when checking repo units if the user is nil (go-gitea#19625)
  Skip duplicated layers. (go-gitea#19624)
  Add "Reference" section to Issue view sidebar (go-gitea#19609)
  GetFeeds must always discard actions with dangling repo_id (go-gitea#19598)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants