Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete related PullAutoMerge and ReviewState on User/Repo Deletion #19649

Merged
merged 12 commits into from
May 8, 2022
Merged

Delete related PullAutoMerge and ReviewState on User/Repo Deletion #19649

merged 12 commits into from
May 8, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented May 7, 2022 •
edited
Loading

follow up of: #9307 & #19007

TODO:

  • fix import cycle(s)

@6543 6543 added the pr/wip This PR is not ready for review label May 7, 2022
@6543 6543 added this to the 1.17.0 milestone May 7, 2022
@6543 6543 added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed pr/wip This PR is not ready for review labels May 7, 2022
@6543 6543 marked this pull request as ready for review May 7, 2022 19:35
6543
6543 commented May 7, 2022
View reviewed changes
models/pull/automerge.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2022
6543
6543 commented May 7, 2022
View reviewed changes
services/pull/automerge.go Outdated Show resolved Hide resolved
@6543 6543 requested review from delvh and wxiaoguang May 7, 2022 19:50
@6543 6543 mentioned this pull request May 7, 2022
Merged
2 tasks
delvh
delvh reviewed May 7, 2022
View reviewed changes
models/db/error.go Show resolved Hide resolved
models/db/error.go Show resolved Hide resolved
models/pull/automerge.go Show resolved Hide resolved
models/issue_tracked_time.go Show resolved Hide resolved
models/issue_tracked_time.go Show resolved Hide resolved
models/issue_tracked_time.go Show resolved Hide resolved
models/notification.go Show resolved Hide resolved
models/issue_comment.go Show resolved Hide resolved
@6543 @delvh
add insurance to models/issue_comment.go
a94d9c1 
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2022
wxiaoguang
wxiaoguang approved these changes May 8, 2022
View reviewed changes
models/pull.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2022
@6543 6543 merged commit 6a96968 into go-gitea:main May 8, 2022
@6543 6543 deleted the auto-merge_delete branch May 8, 2022 13:46
6543 added a commit to 6543-forks/gitea that referenced this pull request May 8, 2022
@6543
ajust to go-gitea#19649
f1037f3
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 8, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
96e8813 
* giteaofficial/main:
  Delete related PullAutoMerge and ReviewState on User/Repo Deletion (go-gitea#19649)
  Allow custom default merge message with .gitea/default_merge_message/<merge_style>_TEMPLATE.md (go-gitea#18177)
  Allow to mark files in a PR as viewed (go-gitea#19007)
  Auto merge pull requests when all checks succeeded via API (go-gitea#9307)
  Hide private repositories in packages (go-gitea#19584)
  Only show accessible teams in dashboard dropdown list (go-gitea#19642)
  prevent double click new issue/pull/comment button (go-gitea#16157)
  Improve reviewing PR UX (go-gitea#19612)
  [skip ci] Updated translations via Crowdin
  Add Changelog v1.16.7 (go-gitea#19575) (go-gitea#19644)
  Set safe dir for git operations in .drone.yml CI (go-gitea#19641)
  Add missing `sorting` column in `project_issue` table (go-gitea#19635)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @AbdulrhmnGhanem
Delete related PullAutoMerge and ReviewState on User/Repo Deletion (g…
b80b656 
…o-gitea#19649)

* delete pullautomerges on repo/user deletion
* delete reviewstates on repo/user deletion
* optimize automerhe code
* add index to reviewstate
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @lunny @wxiaoguang @delvh @GiteaBot