Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uppercase default branch bug #1965

Merged
merged 1 commit into from Jun 14, 2017
Merged

Fix uppercase default branch bug #1965

merged 1 commit into from Jun 14, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #1963. Also add an integration test.

@lafriks
Copy link
Member

lafriks commented Jun 13, 2017

LGTM, nice to see integration test! Great job!

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 13, 2017
@lunny lunny added the type/bug label Jun 14, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 14, 2017
@lunny
Copy link
Member

lunny commented Jun 14, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 14, 2017
@lunny lunny merged commit 5e92b82 into go-gitea:master Jun 14, 2017
@ethantkoenig ethantkoenig deleted the fix/default_branch branch June 14, 2017 01:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@algernon @earl-warren
[GITEA] repo: Don't redirect the repo to external units
92f41d1 
When displaying the repo home view, do not redirect to unit types that
can't be defaults (which, at the moment, are the external wiki and issue
tracker unit types).

If we'd redirect to those, that would mean that a repository with the
Code unit disabled, and an external issue tracker would immediately
redirect to the external issue tracker, making it harder to reach other,
non-external units of the repo.

Fixes go-gitea#1965.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 44078e546022e25f5c805ef047fbc3b7c6075ec0)
(cherry picked from commit 1868dec2e4c2ba8e6807336e6dabd83e6138bcac)
(cherry picked from commit c3a8e9887092c8c089462a1cdb22a404aa11beb6)
(cherry picked from commit 9266b1916f1577075b0bf2ff14c7412cbd7cae43)
(cherry picked from commit 8fa5ff65af91c33df692a52457fe65e71c4bc3c1)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Fail to change default branch if branch name have uppercase chatacter
4 participants
@ethantkoenig @lafriks @lunny @tboerger