Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodeinfo caching and prevent NPE if cache non-existent #19721

Merged
merged 1 commit into from
May 16, 2022

Conversation

zeripath
Copy link
Contributor

Extract from #19703

Signed-off-by: Andrew Thornton art27@cantab.net

Extract from go-gitea#19703

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 16, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2022
@lunny lunny merged commit d494cc3 into go-gitea:main May 16, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 16, 2022
* giteaofficial/main:
  Fix issue overview for teams (go-gitea#19652)
  Fix nodeinfo caching and prevent NPE if cache non-existent (go-gitea#19721)
  Update go-chi/cache to utilize Ping() (go-gitea#19719)
  Disable blank issues (go-gitea#19717)
  clarify what session provider 'db' does (go-gitea#19713)
  [skip ci] Updated translations via Crowdin
@zeripath zeripath deleted the fix-nodeinfo-caching-extract-19703 branch May 16, 2022 21:53
@zeripath
Copy link
Contributor Author

No need to backport as 1.16 doesn't contain the problem code

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
…19721)

Extract from go-gitea#19703

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants