use http.StatusTemporaryRedirect(307) when serve avatar directly #19739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use http.StatusTemporaryRedirect(307) when serve avatar directly browser caches 301 redirections, pre-signed s3 url would expire at some later point
yankeguo
changed the title
Codecov Report
@@ Coverage Diff @@
## main #19739 +/- ##
==========================================
+ Coverage 47.22% 47.39% +0.17%
==========================================
Files 958 958
Lines 133603 133603
==========================================
+ Hits 63088 63326 +238
+ Misses 62871 62614 -257
- Partials 7644 7663 +19
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
May 18, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
May 18, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 19, 2022
* giteaofficial/main: Update base.go (go-gitea#19739) [doctor] do not update User Stars numbers unless --fix (go-gitea#19750) Fix incorrect translation key (go-gitea#19744) Improved ref comment link when origin is body/title (go-gitea#19741) [doctor] explain what enable-push-options does (go-gitea#19740)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
use http.StatusTemporaryRedirect(307) when serve avatar directly browser caches 301 redirections, pre-signed s3 url would expire at some later point Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use http.StatusTemporaryRedirect(307) when serve avatar directly
browser caches 301 redirections, pre-signed s3 url would expire at some later point