Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golint error and rename func for suggestion. #1997

Merged
merged 1 commit into from
Jun 17, 2017
Merged

fix golint error and rename func for suggestion. #1997

merged 1 commit into from
Jun 17, 2017

Conversation

appleboy
Copy link
Member

  • Add the missing comment.
  • Rename HtmlDoc => HTMLDoc
  • Rename NewHtmlParser => NewHTMLParser

@appleboy
fix golint error and rename func for suggestion.
0f9c975 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy added this to the 1.2.0 milestone Jun 17, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jun 17, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2017
@lafriks
Copy link
Member

lafriks commented Jun 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2017
@appleboy appleboy merged commit 90f9bb1 into go-gitea:master Jun 17, 2017
@appleboy appleboy deleted the golint2 branch June 17, 2017 16:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@appleboy @bkcsoft @lafriks @tboerger