Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording #2024

Merged
merged 3 commits into from Jun 24, 2017
Merged

Fix wording #2024

merged 3 commits into from Jun 24, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Jun 20, 2017

For a key which never expires, it used to say Valid until never. It should be forever.

@lunny
Copy link
Member

lunny commented Jun 21, 2017

Maybe we should change the key and there are any other places to use this word?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Jun 22, 2017 •
edited

@lunny No, there are not any other places using this word. If you want, I can change the key.

@lafriks
Copy link
Member

lafriks commented Jun 22, 2017

I think the key should be changed

@lunny lunny added this to the 1.2.0 milestone Jun 23, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jun 23, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Jun 23, 2017

Done. I have added a new key settings.valid_forever and removed settings.never.

The failed build is not because of this.

Proof: https://staging.geek1011.net/user/login?redirect_to=%2fuser%2fsettings%2fkeys
screenshot from 2017-06-23 17-56-17

@lafriks
Copy link
Member

lafriks commented Jun 23, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2017
@lunny
Copy link
Member

lunny commented Jun 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2017
@appleboy appleboy merged commit bf18730 into go-gitea:master Jun 24, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pgaskin @lunny @lafriks @appleboy @tboerger