Support wildcards in email domain whitelisting

[KingBain]

Fixes #20255

[KingBain]

@lunny @Gusted made the chnages to use a []glob.Glob. I'm hoping this is what you had in mind :)

[Gusted]

@lunny @Gusted made the chnages to use a []glob.Glob. I'm hoping this is what you had in mind :)

It's going into the right direction. However the best thing you can do here is to only run the compile code once and then store the result.

So please change the code in modules/settings/service.go, such that the []glob.Glob is the stored output on the EmailDomain{Block,White}list. You will need to change the type of those fields([]string -> []glob.Glob) and then simply wrap the current code into the compile glob function(ex. sec.Key("EMAIL_DOMAIN_WHITELIST").Strings(",") -> BuildEmailGlobs(sec.Key("EMAIL_DOMAIN_WHITELIST").Strings(","))) and also move the BuildEmailGlobs function into that file.

[KingBain]

Hey, @Gusted thanks for the help. I made the changes. but needed to copy the BuildEmailGlobs function to both service.go and user_form_test.go for everything to work.

was me copying BuildEmailGlobs to user_form_test.go the right thing to do ? Is there a better way to call that function ?

Thanks in advance.

[KingBain]

Correction figured out how to call BuildEmailGlobs from setting package in user_form test

[KingBain]

I dont want to jinx the process, but if you're happy with the PR. Could we also include a change to rename 'setting.Service.EmailDomainWhitelist' to 'setting.Service.EmailDomainAllowlist' .

I understand why folks stopped using Blacklist, but for symmetry probably worth changing 'Whitelist' to reflect the opposite of 'Blocklist' used in EmailDomainBlocklist .

[Gusted]

Code looks good, might want to add documentation in config-cheat-sheet that EMAIL_DOMAIN_WHITELIST and EMAIL_DOMAIN_BLOCKLIST will be compiled to globs, with a link to https://pkg.go.dev/github.com/gobwas/glob#Compile which list the "syntax".

[wxiaoguang]

Is this PR still in progress? Long time since last review suggestion.

At least, the app.example.ini and cheatsheet.md should be updated with "it supports wildcard"

[wxiaoguang]

Replaced by Support wildcard in email domain allow/block list #24831, since this PR is stale and incomplete.