Slightly simplify LastCommitCache #20444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LastCommitCache code is a little complex and there is unnecessary duplication between the gogit and nogogit variants. This PR adds the LastCommitCache as a field to the git.Repository and pre-creates it in the ReferencesGit helpers etc. There has been some simplification and unification of the variant code. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/refactoring
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## main #20444 +/- ##
=======================================
Coverage ? 46.88%
=======================================
Files ? 977
Lines ? 135250
Branches ? 0
=======================================
Hits ? 63408
Misses ? 64064
Partials ? 7778
Help us with your feedback. Take ten seconds to tell us how you rate us. |
GiteaBot
added
the
lgtm/need 2
zeripath
commented
Jul 22, 2022
silverwind
approved these changes
Jul 23, 2022
GiteaBot
added
lgtm/need 1
Gusted
reviewed
Jul 23, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
commented
Jul 24, 2022
Gusted
approved these changes
Jul 24, 2022
GiteaBot
added
lgtm/done
|
make lgtm work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 27, 2022
* giteaofficial/main: Hide internal package versions (go-gitea#20492) Fix org members bug (go-gitea#20489) Add labels to two buttons that were missing them (go-gitea#20419) fix enabling repo packages when projects are off (go-gitea#20486) Display project in issue list (go-gitea#20434) Make code review ceckboxes clickable (go-gitea#20481) Slightly simplify LastCommitCache (go-gitea#20444)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
The LastCommitCache code is a little complex and there is unnecessary duplication between the gogit and nogogit variants. This PR adds the LastCommitCache as a field to the git.Repository and pre-creates it in the ReferencesGit helpers etc. There has been some simplification and unification of the variant code. Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LastCommitCache code is a little complex and there is unnecessary
duplication between the gogit and nogogit variants.
This PR adds the LastCommitCache as a field to the git.Repository and
pre-creates it in the ReferencesGit helpers etc. There has been some
simplification and unification of the variant code.
Signed-off-by: Andrew Thornton art27@cantab.net