Disable doctor logging on panic #20847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If permissions are incorrect for writing to the doctor log simply disable the log file instead of panicing. Related go-gitea#20570 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/enhancement
delvh
reviewed
Aug 18, 2022
GiteaBot
added
lgtm/need 2
|
Would it make sense for the logger to do this instead? Disable requested loggers if errors arise and use console as ultimate fallback. |
delvh
reviewed
Aug 18, 2022
Co-authored-by: delvh <dev.lh@web.de>
This is for TRACE level logging. We probably shouldn't even be logging this stuff by default - doctor will still be writing its output to stdout. |
Gusted
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 19, 2022
* giteaofficial/main: Fix create repository page's help text (go-gitea#20810) In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (go-gitea#20837) Disable doctor logging on panic (go-gitea#20847) Remove calls to load Mirrors in user.Dashboard (go-gitea#20855) switch to node18 for snapcraft Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (go-gitea#20839) Fix owners cannot create organization repos bug (go-gitea#20841)
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 21, 2022
Backport go-gitea#20847 If permissions are incorrect for writing to the doctor log simply disable the log file instead of panicing. Related go-gitea#20570 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>
zeripath
added a commit
that referenced
this pull request
Aug 24, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
* Disable doctor logging on panic If permissions are incorrect for writing to the doctor log simply disable the log file instead of panicing. Related go-gitea#20570 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update cmd/doctor.go * Update cmd/doctor.go Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If permissions are incorrect for writing to the doctor log simply disable the log file
instead of panicing.
Related #20570
Signed-off-by: Andrew Thornton art27@cantab.net