Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mode of custom dir to 0700 in docker-rootless #20861

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

wxiaoguang
Copy link
Contributor

The 0500 came from #10154, more than 2 years ago. Maybe at that time people think that this directory wouldn't be changed anymore and make it secure. However, more and more directories may be added during Gitea's development.

Close #20570

Some things that I still do not fully understand:

  • Is there any other purpose for the 0500?
  • Since 1.17 has been released for a long time, why there is only a few (one?) issues reporting about it.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2022
@lunny lunny added type/bug backport/v1.17 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 19, 2022
@techknowlogick techknowlogick merged commit 7258a12 into go-gitea:main Aug 19, 2022
@wxiaoguang wxiaoguang deleted the fix-docker-rootless-custom branch August 19, 2022 15:06
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Aug 19, 2022
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Aug 19, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 22, 2022
* giteaofficial/main:
  update current stable version
  [skip ci] Updated translations via Crowdin
  Fix mirror address setting not working (go-gitea#20850)
  Support Proxy protocol (go-gitea#12527)
  Fix SQL Query for `SearchTeam` (go-gitea#20844)
  Double check CloneURL is acceptable (go-gitea#20869)
  Fix graceful doc (go-gitea#20883)
  Pad GPG Key ID with preceding zeroes (go-gitea#20878)
  [skip ci] Updated translations via Crowdin
  call builtinUnused() if internal SSH is disabled (go-gitea#20877)
  Don't open new page for ext wiki on same repository (go-gitea#20725)
  [skip ci] Updated translations via Crowdin
  Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861)
  Fix UI mis-align for PR commit history (go-gitea#20845)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 7, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied error when starting Gitea after updating to 1.17.0
5 participants