Return 404 NotFound if requested attachment does not exist #20886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to test if GetAttachmentByID returns an ErrAttachmentNotExist error and return NotFound instead of InternalServerError Fix go-gitea#20884 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
requested changes
Aug 22, 2022
GiteaBot
added
the
lgtm/need 2
zeripath
commented
Aug 22, 2022
zeripath
commented
Aug 22, 2022
lunny
approved these changes
Aug 24, 2022
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Aug 24, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Aug 24, 2022
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 24, 2022
…20886) Backport go-gitea#20886 Add code to test if GetAttachmentByID returns an ErrAttachmentNotExist error and return NotFound instead of InternalServerError Fix go-gitea#20884 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny
added a commit
that referenced
this pull request
Aug 25, 2022
…20941) Backport #20886 Add code to test if GetAttachmentByID returns an ErrAttachmentNotExist error and return NotFound instead of InternalServerError Fix #20884 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 25, 2022
* upstream/main: Fix input.value attr for RequiredClaimName/Value (go-gitea#20946) Move some files into models' sub packages (go-gitea#20262) [skip ci] Updated translations via Crowdin docs[zh-cn]: Install on Kubernetes (go-gitea#20874) Return 404 NotFound if requested attachment does not exist (go-gitea#20886) Avoid frequent string2bytes conversions (go-gitea#20940)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
…20886) Add code to test if GetAttachmentByID returns an ErrAttachmentNotExist error and return NotFound instead of InternalServerError Fix go-gitea#20884 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to test if GetAttachmentByID returns an ErrAttachmentNotExist error
and return NotFound instead of InternalServerError
Fix #20884
Signed-off-by: Andrew Thornton art27@cantab.net