Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git hooks update to receive required arguments #2095

Merged
merged 1 commit into from Jul 2, 2017
Merged

Fix git hooks update to receive required arguments #2095

merged 1 commit into from Jul 2, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 1, 2017

Fixes #2090

  • Changed migration calling so that migrations can use models package

@lafriks lafriks added this to the 1.2.0 milestone Jul 1, 2017
@lafriks lafriks mentioned this pull request Jul 1, 2017
Closed
7 tasks
@lafriks
Fix git hooks update to receive required arguments. Fixes go-gitea#2090
e9fa637 
* Changed migration calling so that migrations can use models package
@lafriks lafriks changed the title Fix git hooks update to receive required arguments. Fix git hooks update to receive required arguments Jul 1, 2017
@lunny
Copy link
Member

lunny commented Jul 2, 2017

@lafriks any chance to integrate your test codes on this PR?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jul 2, 2017

@lunny unless the test runs git push we can't test this :(

@lunny
Copy link
Member

lunny commented Jul 2, 2017

Oh. This clone test PR #1682 need go1.8

@lafriks
Copy link
Member Author

lafriks commented Jul 2, 2017

It's not easy to test this as this need clone and later push and parsing push output to check if this

@lunny
Copy link
Member

lunny commented Jul 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 2, 2017
@Bwko
Copy link
Member

Bwko commented Jul 2, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 2, 2017
@lunny lunny merged commit f189ccd into go-gitea:master Jul 2, 2017
@lafriks lafriks deleted the fix/git_server_hooks branch July 2, 2017 13:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Git-Hook for update does not get the refname, oldrev, newrev as parameter
5 participants
@lafriks @lunny @bkcsoft @Bwko @tboerger