Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc and heatmap for the Vue3 refactoring #21312

Merged
merged 2 commits into from Oct 2, 2022
Merged

Fix doc and heatmap for the Vue3 refactoring #21312

merged 2 commits into from Oct 2, 2022

Conversation

wxiaoguang
Copy link
Contributor

The heat map has been tested with various size:

image

image

image

@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 1, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 1, 2022
@wxiaoguang wxiaoguang linked an issue Oct 1, 2022 that may be closed by this pull request
TODOs for the Vue3 refactoring #21311
Closed
@wxiaoguang wxiaoguang mentioned this pull request Oct 1, 2022
Closed
1 task
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 1, 2022
delvh
delvh approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs part is fine.
I have no idea what the heatmap part changes, I already didn't see a difference in your screenshots.

Additionally, doesn't this close #21311?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 1, 2022
@wxiaoguang
Copy link
Contributor Author

Docs part is fine. I have no idea what the heatmap part changes, I already didn't see a difference in your screenshots.

It fixes the problem in #19902 (comment) (caused by the refactoring)

Additionally, doesn't this close #21311?

Yup

@wxiaoguang wxiaoguang merged commit eaa6767 into go-gitea:main Oct 2, 2022
@wxiaoguang wxiaoguang deleted the fix-vue3 branch October 2, 2022 02:13
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@Ryuno-Ki Ryuno-Ki Ryuno-Ki left review comments

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

TODOs for the Vue3 refactoring
6 participants
@wxiaoguang @silverwind @lafriks @Ryuno-Ki @delvh @GiteaBot