Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump playwright to 1.26.1 #21357

Merged
merged 2 commits into from Oct 8, 2022
Merged

Bump playwright to 1.26.1 #21357

merged 2 commits into from Oct 8, 2022

Conversation

kdumontnu
Copy link
Contributor

Potentially addresses #21355

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 6, 2022
@delvh
Copy link
Member

delvh commented Oct 6, 2022

Nope, still present.

@silverwind
Copy link
Member

silverwind commented Oct 6, 2022 •
edited

I wonder whether this browser object is really needed or if one can just use only page only everywhere.

silverwind
silverwind approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency bump is good to have on its own.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2022
@wxiaoguang
Copy link
Contributor

The browser is not related to this problem. The problem here is firefox can not call newPage (even without the browser, the test framework still need to call newPage to open a new page for test).

Just a guess: I can see a suspicious error log Sandbox: thread-synchronized seccomp failed: Unknown error 524, so I suspect that this problem is caused by host docker's seccomp policy. Firefox needs to set seccomp+tsync, but it fails, then firefox crashes.

@silverwind
Copy link
Member

silverwind commented Oct 7, 2022 •
edited

Please restart CI here. It should work now with #21363.

@wxiaoguang wxiaoguang merged commit 7bb12d7 into go-gitea:main Oct 8, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
63c503f 
* upstream/main:
  Add user/organization code search (go-gitea#19977)
  Stop logging CheckPath returns error: context canceled (go-gitea#21064)
  Hook go-licenses into tidy again (go-gitea#21353)
  Fix missing left and right carets in TRANSLATORS (go-gitea#21397)
  Fix calls to i18n in templates (go-gitea#21394)
  Update JS dependencies and eslint config (go-gitea#21388)
  Allow creation of OAuth2 applications for orgs (go-gitea#18084)
  Fix typos in PullRequestMergeForm.vue header comment (go-gitea#21378)
  Use weighted algorithm for string matching when finding files in repo (go-gitea#21370)
  Bump playwright to 1.26.1 (go-gitea#21357)
  npm package registry support for `bin` (go-gitea#21372)
  Removed one extra whitespace in footer after "Template" (go-gitea#21364)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kdumontnu @delvh @silverwind @wxiaoguang @GiteaBot