Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key usage time update if the key is used in parallel for multiple operations #2185

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 19, 2017

Fixes #2060

In case of MySQL update will return 0 affected rows if values has not changed and is not reliable to check record existence.

@lafriks lafriks added this to the 1.2.0 milestone Jul 19, 2017
@lunny
Copy link
Member

lunny commented Jul 20, 2017

LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 20, 2017
@lunny
Copy link
Member

lunny commented Jul 20, 2017

make L-G-T-M work

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 20, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 20, 2017
@lunny lunny merged commit dde0052 into go-gitea:master Jul 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdatePublicKey: Failed to update public key: public key does not exist
4 participants