Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permission check on issue/pull lock #22110

Merged
merged 2 commits into from Dec 12, 2022
Merged

Fix permission check on issue/pull lock #22110

merged 2 commits into from Dec 12, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 12, 2022

Fix #21826

@lunny lunny added type/bug backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Dec 12, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2022
@lunny lunny merged commit 87c64f6 into go-gitea:main Dec 12, 2022
@lunny lunny deleted the lunny/fix_issue_lock_perm branch December 12, 2022 15:02
This was referenced Dec 12, 2022
Merged
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 12, 2022
KN4CK3R pushed a commit that referenced this pull request Dec 12, 2022
@lunny
Fix permission check on issue/pull lock (#22114)
a8534ac 
Fix #22110
KN4CK3R pushed a commit that referenced this pull request Dec 12, 2022
@lunny
Fix permission check on issue/pull lock (#22113)
079ef56 
backport #22110
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 13, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
01d8f70 
* upstream/main:
  Fix permission check on issue/pull lock (go-gitea#22110)
  Add a simple test for external renderer (go-gitea#20033)
  refactor bind functions based on generics (go-gitea#22055)
  Allow disable code tab (go-gitea#20805)
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this pull request Dec 30, 2022
Merged
@yardenshoham yardenshoham added backport/done All backports for this PR have been created outdated/backport/v1.18 This PR should be backported to Gitea 1.18 and removed backport/done All backports for this PR have been created outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Jan 27, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 on POST for Lock PR conversation
5 participants
@lunny @a1012112796 @delvh @yardenshoham @GiteaBot