Fix counts on issues dashboard #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfranz
reviewed
Jul 28, 2017
models/issue.go
Outdated
| func Issues(opts *IssuesOptions) ([]*Issue, error) { | ||
| var sess *xorm.Session | ||
| if opts.Page >= 0 { | ||
| func (opts *IssuesOptions) setupSess(sess *xorm.Session) error { |
There was a problem hiding this comment.
Why not change this function name to setupSession? It would be more precise.
|
Can you add integration test for this? |
bkcsoft
added
the
lgtm/need 2
|
@lafriks Test added. I decided to add a unit test instead of an integration test; IMO it's not sustainable to have a separate integration test for every possible corner case. |
ethantkoenig
force-pushed
the
fix/issues_counts
branch
from
e9745a4
to
a86d736
Compare
|
When I visit http://localhost:3000/issues?type=all&repo=2&sort=&state=open, 500 returned. |
|
|
|
@lunny Good catch, fixed |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1325.
There is still a problem with the
In your repositories/Assigned to you/Created by youcounts, which always show the open counts, even if the user is looking at closed issues. I will fix this is a separate PR.