Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift package registry #22404

Merged
merged 10 commits into from Mar 13, 2023
Merged

Add Swift package registry #22404

merged 10 commits into from Mar 13, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jan 11, 2023

This PR adds a Swift package registry.

grafik

@KN4CK3R KN4CK3R added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/packages labels Jan 11, 2023
@KN4CK3R KN4CK3R added this to the 1.19.0 milestone Jan 11, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 22, 2023
@delvh delvh modified the milestones: 1.19.0, 1.20.0 Feb 19, 2023
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished the code review without a test. Trusted Approval.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2023
r.Group("/{version}", func() {
r.Get("/Package.swift", swift.CheckAcceptMediaType(swift.AcceptSwift), swift.DownloadManifest)
r.Put("", reqPackageAccess(perm.AccessModeWrite), swift.CheckAcceptMediaType(swift.AcceptJSON), swift.UploadPackageFile)
r.Get("", func(ctx *context.Context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this code block be moved into a swfit-related go file to keep the api.go simple?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep it here because it's not "swift logic" but "router logic". The docker part at the end of the file does something similar.

@codecov-commenter
Copy link

Codecov Report

Merging #22404 (6328f6d) into main (d74a7ef) will increase coverage by 47.18%.
The diff coverage is 71.39%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           main   #22404       +/-   ##
=========================================
+ Coverage      0   47.18%   +47.18%     
=========================================
  Files         0     1151     +1151     
  Lines         0   151938   +151938     
=========================================
+ Hits          0    71697    +71697     
- Misses        0    71775    +71775     
- Partials      0     8466     +8466     
Impacted Files Coverage Δ
models/packages/package.go 45.45% <0.00%> (ø)
services/forms/package_form.go 0.00% <ø> (ø)
modules/packages/swift/metadata.go 58.76% <58.76%> (ø)
routers/api/packages/swift/swift.go 72.86% <72.86%> (ø)
models/packages/descriptor.go 68.18% <100.00%> (ø)
modules/setting/packages.go 86.95% <100.00%> (ø)
routers/api/packages/api.go 90.51% <100.00%> (ø)
routers/api/v1/packages/package.go 88.82% <100.00%> (ø)
services/packages/packages.go 59.51% <100.00%> (ø)

... and 1142 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit c709fa1 into go-gitea:main Mar 13, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2023
@KN4CK3R KN4CK3R deleted the feature-swift branch March 14, 2023 15:18
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants