Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user rename endpoint to admin api #22789

Merged
merged 27 commits into from
Mar 14, 2023
Merged

add user rename endpoint to admin api #22789

merged 27 commits into from
Mar 14, 2023

Conversation

techknowlogick
Copy link
Member

this is a simple endpoint that adds the ability to rename users to the admin API.

Note: this is not in a mergeable state. It would be better if this was handled by a PATCH/POST to the /api/v1/admin/users/{username} endpoint and the username is modified.

@techknowlogick techknowlogick changed the title WIP: add user rename endpoint to admin api add user rename endpoint to admin api Feb 20, 2023
@techknowlogick techknowlogick marked this pull request as ready for review February 20, 2023 17:40
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 2, 2023
@techknowlogick techknowlogick added type/feature Completely new functionality. Can only be merged if feature freeze is not active. modifies/api This PR adds API routes or modifies them labels Mar 2, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2023
lunny
lunny reviewed Mar 2, 2023
View reviewed changes
routers/api/v1/admin/user.go Outdated Show resolved Hide resolved
drsybren
drsybren reviewed Mar 3, 2023
View reviewed changes
routers/api/v1/admin/user.go Outdated Show resolved Hide resolved
templates/swagger/v1_json.tmpl Outdated Show resolved Hide resolved
templates/swagger/v1_json.tmpl Outdated Show resolved Hide resolved
lunny
lunny reviewed Mar 9, 2023
View reviewed changes
services/user/rename.go Outdated Show resolved Hide resolved
@codecov-commenter

This comment was marked as off-topic.

Sign in to view
lunny
lunny approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with my reviews. :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2023
@techknowlogick
Copy link
Member Author

@lunny thank you for your reviews :) Your reviews made this to be better code.

wolfogre
wolfogre approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@wolfogre wolfogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting, not blocking.

services/user/rename.go Outdated Show resolved Hide resolved
services/user/rename.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2023
@techknowlogick @wolfogre
Apply suggestions from code review
79ed00f 
Co-authored-by: Jason Song <i@wolfogre.com>
@techknowlogick techknowlogick merged commit 03591f0 into go-gitea:main Mar 14, 2023
@techknowlogick techknowlogick deleted the rename-user-endpoint branch March 14, 2023 07:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 15, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a4a7dce 
* giteaofficial/main: (33 commits)
  Bump webpack from 5.75.0 to 5.76.0 (go-gitea#23484)
  Replace Less with CSS (go-gitea#23481)
  Fix 'View File' button in code search (go-gitea#23478)
  Use `gitea/test_env` image instead of `golang` (go-gitea#23455)
  Skip DB tests duplicate runs on push to branches (go-gitea#23476)
  Update app.example.ini (go-gitea#23480)
  [skip ci] Updated translations via Crowdin
  Fix due date being wrong on issue list (go-gitea#23475)
  test_env: hardcode major go version in use (go-gitea#23464)
  Push option bonus for PTC docs (go-gitea#23473)
  Lint Markdown pass
  Push to create docs (go-gitea#23458)
  Convert GitHub event on actions and fix some pull_request events. (go-gitea#23037)
  Remove wrongly added column on migration test fixtures (go-gitea#23456)
  Refactor branch/tag selector to Vue SFC (go-gitea#23421)
  add admin API email endpoints (go-gitea#22792)
  add user rename endpoint to admin api (go-gitea#22789)
  Add workflow error notification in ui (go-gitea#23404)
  Make branches list page operations remember current page (go-gitea#23420)
  fix markdown lint issue (go-gitea#23457)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@drsybren drsybren drsybren left review comments

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@techknowlogick @codecov-commenter @lunny @wxiaoguang @wolfogre @drsybren @GiteaBot