Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stylelint 15 #22944

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Upgrade to stylelint 15 #22944

merged 5 commits into from
Feb 21, 2023

Conversation

silverwind
Copy link
Member

  • Upgrade stylelint and plugin
  • Change ruleset to a explicit one, with all deprecated rules removed
  • Fix new issues detected by value validation

For overflow: overlay see stylelint/stylelint#6667

@silverwind silverwind added dependencies topic/code-linting skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 16, 2023
@silverwind silverwind added this to the 1.19.0 milestone Feb 16, 2023
- Upgrade stylelint and plugin
- Change ruleset to a explicit one, with all deprecated rules removed
- Fix new issues detected by value validation
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2023
@silverwind
Copy link
Member Author

silverwind commented Feb 20, 2023

Stylelint updated to 15.2.0, still passes.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 21, 2023
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 77f70bd into go-gitea:main Feb 21, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 21, 2023
@silverwind silverwind deleted the stylelint-15 branch February 21, 2023 18:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 22, 2023
* upstream/main:
  Changelog 1.18.5 (go-gitea#23045) (go-gitea#23049)
  Add Bash and Zsh completion scripts (go-gitea#22646)
  Return empty url for submodule tree entries (go-gitea#23043)
  Fix the show/hide methods for string selector (go-gitea#23042)
  display attachments of review comment when comment content is blank (go-gitea#23035)
  Upgrade to stylelint 15 (go-gitea#22944)
  Add force_merge to merge request and fix checking mergable (go-gitea#23010)
  Improve PR Review Box UI (go-gitea#22986)
  Remove dashes between organization member avatars on hover (go-gitea#23034)
  Fix the Manually Merged form (go-gitea#23015)
  Remove delete button for review comment (go-gitea#23036)
  Improve frontend guidelines (go-gitea#23007)
  Use `--message=%s` for git commit message (go-gitea#23028)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants