Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve FindProjects #23085

Merged
merged 3 commits into from Feb 24, 2023
Merged

improve FindProjects #23085

merged 3 commits into from Feb 24, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 23, 2023

I found FindAndCount which can Find and Count in the same time
Maybe it is better to use it in FindProjects

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 23, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Feb 23, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2023
wolfogre
wolfogre reviewed Feb 23, 2023
View reviewed changes
models/project/project.go Outdated Show resolved Hide resolved
delvh
delvh approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with both the proposed options as they should be equivalent.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2023
@lunny lunny merged commit 5b87c05 into go-gitea:main Feb 24, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
02f7298 
* giteaoffical/main:
  Fix db.Find bug (go-gitea#23115)
  Avoid warning for system setting when start up (go-gitea#23054)
  Require approval to run actions for fork pull request (go-gitea#22803)
  Fix nil context in RenderMarkdownToHtml (go-gitea#23092)
  Add HesterG to maintainers (go-gitea#23104)
  improve FindProjects (go-gitea#23085)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre left review comments

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yp05327 @lunny @wolfogre @delvh @techknowlogick @GiteaBot