update latest xorm version to vendor #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
topic/build
|
@lunny drone fails |
tboerger
added
the
lgtm/need 2
|
@lafriks could you help me? don't know what's wrong with my govendor. |
|
@lunny I suspect that you have a different EOL than the one on linux. So, when computing hash it doesn't come to the same result. There is an issue on govendor : https://github.com/kardianos/govendor/issues/129#issuecomment-270008849 I will try to generate the hash today and give them to you if anyone haven't done it yet. |
|
LGTM (if I'm allowed to do that :) ) |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Aug 22, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.