Fix pagination on /notifications/watching
#23564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
/notifications/watching pageq on /notifications/watching page
silverwind
added
type/bug
outdated/backport/v1.19
delvh
approved these changes
Mar 18, 2023
GiteaBot
added
the
lgtm/need 1
silverwind
changed the title
q on /notifications/watching page/notifications/watching page
silverwind
changed the title
/notifications/watching page/notifications/watching
yardenshoham
suggested changes
Mar 20, 2023
There was a problem hiding this comment.
To avoid duplication you could use keyword instead of ctx.FormTrim("q") in
gitea/routers/web/user/notification.go
Line 381 in 529bac1
silverwind
force-pushed
the
watching-pagination
branch
from
dc23963
to
deac5a6
Compare
yardenshoham
approved these changes
Mar 20, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
|
🎺 🤖 |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 21, 2023
The `q` parameter was not rendered in pagination links because `context.Pagination:AddParam` checks for existance of the parameter in `ctx.Data` where it was absent. Added the parameter there to fix it.
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 21, 2023
* upstream/main: Replace a few fontawesome icons with svg (go-gitea#23602) Fix pagination on `/notifications/watching` (go-gitea#23564) Fix `.locale.Tr` function not found in delete modal (go-gitea#23468) fix submodule is nil panic (go-gitea#23588) `Publish Review` buttons should indicate why they are disabled (go-gitea#23598) Improve template error reporting (go-gitea#23396) Polyfill the window.customElements (go-gitea#23592) Add CHANGELOG for 1.19.0 (go-gitea#23583)
jolheiser
pushed a commit
that referenced
this pull request
Mar 21, 2023
Backport #23564 by @silverwind The `q` parameter was not rendered in pagination links because `context.Pagination:AddParam` checks for existance of the parameter in `ctx.Data` where it was absent. Added the parameter there to fix it. Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
qparameter was not rendered in pagination links becausecontext.Pagination:AddParamchecks for existance of the parameter inctx.Datawhere it was absent. Added the parameter there to fix it.