Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary runner logs in gitea #23646

Open
yp05327 opened this issue Mar 23, 2023 · 7 comments
Open

Reduce unnecessary runner logs in gitea #23646

yp05327 opened this issue Mar 23, 2023 · 7 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@yp05327
Copy link
Contributor

yp05327 commented Mar 23, 2023

Feature Description

There are too many same FetchTask POST request logs in gitea which is unnecessary I think.
Maybe we can add a setting in app.ini to cut off these logs which have no errors.

For example:
logs, in #23636

Screenshots

No response

@yp05327 yp05327 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 23, 2023
@wolfogre
Copy link
Member

wolfogre commented Mar 23, 2023

Actually, the logs are printed by routers logs, and the runners have to send requests to Gitea periodically.

Every HTTP request will cause a log line, even requests for js/css:

image

You could disable routers logs or config it to file, like:

[log]
MODE = console
;DISABLE_ROUTER_LOG=false
ROUTER = file

@wolfogre wolfogre closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@wolfogre
Copy link
Member

Reopen because maybe we can provide a filter for routers logs(or Gitea already has? I am not sure)

@wolfogre wolfogre reopened this Mar 23, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 23, 2023

IMO router logs are important in sometimes, but the request logs with no errors from runner, and repeat too many times like calling FetchTask, are not so important to be logged.
I don’t think simply disable router logs is a good answer for this problem. I agree to provide a router log filter to fix it.

@wxiaoguang
Copy link
Contributor

Or rewrite the FetchTask to WebSocket, etc

@lunny
Copy link
Member

lunny commented Mar 24, 2023

Or rewrite the FetchTask to WebSocket, etc

It comes from WebSocket ...

@wxiaoguang
Copy link
Contributor

Use WebSocket as a one-time short connection?

@lafriks
Copy link
Member

lafriks commented Mar 24, 2023

Would be nice to classify what to log (UI, static resources, API, actions, internal API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants