Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming mail didn't work on issue creation #23651

Open
inMetaNetworks opened this issue Mar 23, 2023 · 5 comments
Open

Incoming mail didn't work on issue creation #23651

inMetaNetworks opened this issue Mar 23, 2023 · 5 comments
Labels

Comments

@inMetaNetworks
Copy link

Description

Hi,

i tried the new incoming mail feature and it's very nice and working good for me. Except you can't answer to issues when they are created. You can only reply on comments with mail. There is no token generated on issue creation.
v1.19/services/mailer/mail.go#L335

I'm not sure if it's a bug or design. For the background: I "misuse" gitea as an dead simple helpdesk for some people and it's great! Simple setup and nearly zero maintenance, ad/ldap connectivity and so on. And the new incoming mail feature is awesome for that!

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 11

How are you running Gitea?

Local installations on Debian Bullseye, systemd, pgsql.

Database

PostgreSQL

@D-ominik
Copy link

D-ominik commented Aug 30, 2023

The bug is even more serious by the fact that the mail states "View on Gitea or reply directly to this mail". These replies will all be lost.

The same applies to the mails when closing an issue. Once again the text "View on Gitea or reply directly to this mail" but a functional reply to Gitea is not possible.

@CaiCandong
Copy link
Member

I don't have this mailbox service configured locally. Can you show the links to the replies for the three scenarios? (Creating an Issue, Commenting on an Issue and Closing an Issue)

@D-ominik
Copy link

When enabled, email notifications for new comments on an issue include a Reply-To header (among others) with specific parameters to identify the user and issue.
image

The email notifications sent when an issue is created or closed are missing this header. However, the text that you can simply reply directly to this mail is present...

@inMetaNetworks
Copy link
Author

Hi,

issue creation:
no reply to header. If understand https://github.com/go-gitea/gitea/blob/main/services/mailer/mail.go#L335 right, there is no token generated, no Reply-To or List-Post header set, when the issue is created. On creation there is no object comment in the context.

first or later comment:
Reply-To: john.ticket-ticket+AEBQIAACBUFAACRKGFOGQAJFCSYD6VI6BIABWBYEAD6M3XIJ3QBQMAABBYFAACYBAMDAAAAFAQAP4AUY@example.com
closed ticket:
There are mails, which I receive. The mail with the comment only: correct reply-to header. The mail with the notification that the ticket is closed, no reply-to header.

@dajrivera
Copy link

Looks like this is fixed by #27997 in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants