Fix issue due date edit toggle bug #23723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
added
type/bug
topic/ui
delvh
approved these changes
Mar 26, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 27, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
Codecov Report
@@ Coverage Diff @@
## main #23723 +/- ##
===========================================
- Coverage 47.14% 0 -47.15%
===========================================
Files 1149 0 -1149
Lines 151446 0 -151446
===========================================
- Hits 71397 0 -71397
+ Misses 71611 0 -71611
+ Partials 8438 0 -8438 see 1149 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 28, 2023
Use `toggleElem` instead of jQuery's `fadeToggle`, which can't be caught by eslint jquery plugin. Hopefully this could be the last bug for the jQuery show/hide refactoring.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 28, 2023
* upstream/main: Fix issue due date edit toggle bug (go-gitea#23723) Fix profile page email display, respect settings (go-gitea#23747) Update Gitea version in docs (go-gitea#23755) Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751) Remove incorrect HTML self close tag (go-gitea#23748) Refactor repo commit list (go-gitea#23690) Fix tags view (go-gitea#23243) Add commit info in action page (go-gitea#23210) Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
jolheiser
pushed a commit
that referenced
this pull request
Mar 28, 2023
Backport #23723 by @wxiaoguang Use `toggleElem` instead of jQuery's `fadeToggle`, which can't be caught by eslint jquery plugin. Hopefully this could be the last bug for the jQuery show/hide refactoring. Need to backport. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Might need https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/no-fade.md |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
toggleEleminstead of jQuery'sfadeToggle, which can't be caught by eslint jquery plugin.Hopefully this could be the last bug for the jQuery show/hide refactoring.
Need to backport.