Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG close tag, improve commit graph page UI alignment #23751

Merged
merged 2 commits into from Mar 27, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 27, 2023

Follow #23748

Thanks to @delvh


And, fix the UI alignment by the way (adding some gt-mr-xx)

Before:

image

After:

image

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 27, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 27, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 27, 2023
@wxiaoguang
Copy link
Contributor Author

In the screenshot, the avatar image is misaligned (no space between it and the user name) ..... (IIRC there are many misalignment regressions after an old avatar/image refactoring)

So I'd like to fix this misalignment together.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #23751 (ec11ff4) into main (f521e88) will decrease coverage by 0.03%.
The diff coverage is 37.70%.

❗ Current head ec11ff4 differs from pull request most recent head ae9392e. Consider uploading reports for the commit ae9392e to get more accurate results

@@            Coverage Diff             @@
##             main   #23751      +/-   ##
==========================================
- Coverage   47.14%   47.11%   -0.03%     
==========================================
  Files        1149     1155       +6     
  Lines      151446   152496    +1050     
==========================================
+ Hits        71397    71855     +458     
- Misses      71611    72165     +554     
- Partials     8438     8476      +38     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
models/user/search.go 77.50% <0.00%> (-6.29%) ⬇️
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/context/context.go 64.54% <0.00%> (-3.53%) ⬇️
modules/doctor/storage.go 30.65% <0.00%> (-1.29%) ⬇️
modules/setting/git.go 45.45% <ø> (ø)
... and 38 more

... and 47 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wxiaoguang wxiaoguang changed the title Fix SVG close tag Fix SVG close tag, improve commit graph page UI alignment Mar 27, 2023
@zeripath zeripath added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 27, 2023
@zeripath zeripath merged commit dfbefd1 into go-gitea:main Mar 27, 2023
2 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 27, 2023
@wxiaoguang wxiaoguang deleted the fix-svg-tag branch March 27, 2023 19:33
techknowlogick pushed a commit that referenced this pull request Mar 27, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 28, 2023
* upstream/main:
  Fix issue due date edit toggle bug (go-gitea#23723)
  Fix profile page email display, respect settings (go-gitea#23747)
  Update Gitea version in docs (go-gitea#23755)
  Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751)
  Remove incorrect HTML self close tag (go-gitea#23748)
  Refactor repo commit list (go-gitea#23690)
  Fix tags view (go-gitea#23243)
  Add commit info in action page (go-gitea#23210)
  Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023
@6543 6543 added the backport/done All backports for this PR have been created label Apr 11, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants