Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) #23878

Merged
merged 9 commits into from Apr 7, 2023
Merged

Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) #23878

merged 9 commits into from Apr 7, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 2, 2023 •
edited

Backport #23874

@6543 6543 added the type/bug label Apr 2, 2023
@6543 6543 added this to the 1.19.1 milestone Apr 2, 2023
@6543 6543 changed the base branch from main to release/v1.19 April 2, 2023 22:48
@6543 6543 mentioned this pull request Apr 2, 2023
Merged
@6543
Copy link
Member Author

6543 commented Apr 2, 2023 •
edited

this should fail ... with TestGetUserRss as reason ...

TESTed: ack: https://drone.gitea.io/go-gitea/gitea/71240/3/7

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2023
@6543 6543 marked this pull request as ready for review April 2, 2023 23:32
@6543
Copy link
Member Author

6543 commented Apr 2, 2023

fix added ... should pass now

@6543

This comment was marked as outdated.

Sign in to view
@6543 6543 changed the title [Partial Backport] Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) Apr 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@lunny lunny merged commit 085b563 into go-gitea:release/v1.19 Apr 7, 2023
1 check passed
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2023
@6543 6543 deleted the backport_23874_partial branch April 7, 2023 12:27
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @silverwind @wolfogre @lunny @GiteaBot