Update hard-coded version to 1.3.0+dev

[strk]

Was previously set to 1.1.0+dev

[strk]

Sorry this is for 1.3.0+dev (force-pushed).
Will follow PR for 1.2 branch too

[lunny]

How about 1.3.0-dev since it's target is 1.3.0 but isn't reach.

[strk]

I'm still confused about + vs - Before the change we used + What's the difference, semantically ? Will 1.3.0-dev be older than 1.3.0 ? Will 1.3.0+dev be newer than 1.3.0 ?

[sapk]

You forgot to update this like the main.go in the last commit

[strk]

I realized that the test doens't need to match the hard-coded version. I'm actually tempted to use "test" in there instead, to avoid the confusion (and I guess that test could test at least two versions...)

[lunny]

It seems when we build via TAGS="bindata" make generate build, the version is still Gitea version 1.1.0+534-g0307707ca built with: bindata.

[strk]

That's because the Makefile rule generates version via `git describe`, which does not read the hard-coded version number in source code. If you want a better description there, you can add a 1.3 tag pointing to the first commit which got into master branch, ie: git tag 1.3 a915a09

[lunny]

So what's the meaning of the hard-code?

[strk]

It's for when you `go get` or `go build`, or build from sources (outside of a git repository). This PR does not change policy, just fixes its current application

[ethantkoenig]

LGTM

[strk]

@lunny so is this good to merge now ?

[Morlinest]

Shouldn't be version set only when you add tag? Now it should be v1.2.0+dev (or v1.2.x+dev) till next minor/major release.

Edit: Changed - to + as - means pre-release.

[lunny]

For master, I suggest always use - but +. It should be v1.3.0-dev means next release is v1.3.0

[daviian]

LGTM

[codecov-io]

Codecov Report

Merging #2390 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2390   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          86       86           
  Lines       17010    17010           
=======================================
  Hits         4658     4658           
  Misses      11673    11673           
  Partials      679      679

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff26e2...b0178f2. Read the comment docs.