Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll collapsed file into view (#23702) #23929

Merged
merged 1 commit into from Apr 5, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 4, 2023

Backport #23702 by @jpraet

Fixes #23701, #23515.

Alternate approach to #23604 using CSS scroll-margin-top, which is also taken into account for direct links to files in a diff:

@GiteaBot GiteaBot added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 4, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Apr 4, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2023
@lafriks lafriks merged commit df74ee0 into go-gitea:release/v1.19 Apr 5, 2023
2 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@techknowlogick techknowlogick deleted the backport-23702-v1.19 branch September 9, 2023 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants