Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image border-radius (#23886) #23930

Merged
merged 2 commits into from Apr 5, 2023
Merged

Fix image border-radius (#23886) #23930

merged 2 commits into from Apr 5, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 5, 2023

Backport #23886 by @wxiaoguang

  1. Instead of polluting the border-radius style globally, each "img" usage should declare their own styles.
  2. There were some bugs in code, I believe the .img selector was done by mistake.

After:

image

image

@wxiaoguang
Fix image border-radius (go-gitea#23886)
cf052a3 
1. Instead of polluting the `border-radius` style globally, each "img"
usage should declare their own styles.
2. There were some bugs in code, I believe the `.img` selector was done
by mistake.

After:


![image](https://user-images.githubusercontent.com/2114189/229415742-161b018f-14c3-471d-bcf7-34f83e5c2d89.png)


![image](https://user-images.githubusercontent.com/2114189/229415789-829d364a-76da-47a5-8c61-398cc990873c.png)
@GiteaBot GiteaBot added the topic/ui Change the appearance of the Gitea UI label Apr 5, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Apr 5, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 5, 2023

🚀

@KN4CK3R KN4CK3R merged commit 55239cb into go-gitea:release/v1.19 Apr 5, 2023
2 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@techknowlogick techknowlogick deleted the backport-23886-v1.19 branch September 9, 2023 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GiteaBot @KN4CK3R @silverwind @6543 @wxiaoguang