Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom mailer template on Windows #24081

Merged
merged 2 commits into from Apr 12, 2023
Merged

Fix custom mailer template on Windows #24081

merged 2 commits into from Apr 12, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 12, 2023 •
edited

Fix #24075
Fix #23873

From the log:

2023/04/02 19:41:46 .../templates/mailer.go:68:1() [T] Adding mailer template for \issue\default from "C:\gitea\custom\templates\mail\issue\default.tmpl"

That assetName on Windows is wrong. Gitea only uses slash /.

1.20 doesn't have such bug, because the asset system has been refactored.

@wxiaoguang wxiaoguang changed the title fix Fix custom mailer template on Windows Apr 12, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 12, 2023
@wxiaoguang wxiaoguang mentioned this pull request Apr 12, 2023
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2023
@techknowlogick techknowlogick added this to the 1.19.1 milestone Apr 12, 2023
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 12, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 12, 2023 15:03
@techknowlogick techknowlogick merged commit 16d2cf0 into go-gitea:release/v1.19 Apr 12, 2023
2 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 12, 2023
@wxiaoguang wxiaoguang deleted the fix-mailer-path-1.19 branch April 12, 2023 17:09
@wxiaoguang wxiaoguang mentioned this pull request Apr 12, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wxiaoguang @lunny @6543 @delvh @techknowlogick @GiteaBot