Support converting varchar to nvarchar for mssql database (#24105) #24168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
topic/build
silverwind
approved these changes
Apr 17, 2023
GiteaBot
added
the
lgtm/need 1
|
Gonna use this PR to check something with labels real quick |
yardenshoham
added
outdated/backport/v1.19
|
Done |
techknowlogick
approved these changes
Apr 17, 2023
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24105 by @lunny
In #12269, all string fields of struct will generate a NVARCHAR column in database, but for those Gitea instances installed before that PR, users have to convert columns themselves.
In this PR, we update the
./gitea admin convertcommands to support both MySQL and MSSQL database converting. Previously, it only supported convertingutf8 -> utf8mb4for MySQL.Now, it will check the database types.
If it's MSSQL, it will convert
VARCHAR -> NVARCHARas well.