Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access token issue on some public endpoints #24194

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Fix access token issue on some public endpoints #24194

merged 7 commits into from
Apr 21, 2023

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Apr 18, 2023 •
edited
Loading

  • Identify endpoints that should be public
  • Update integration tests

Fix #24159

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2023
@kdumontnu kdumontnu mentioned this pull request Apr 18, 2023
Closed
@wolfogre wolfogre added type/bug modifies/api This PR adds API routes or modifies them outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 19, 2023
@harryzcy harryzcy marked this pull request as ready for review April 20, 2023 03:36
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 21, 2023 15:11
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2023
@techknowlogick
Copy link
Member

🤖 🎺

@techknowlogick techknowlogick merged commit cb19772 into go-gitea:main Apr 21, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2023
@GiteaBot GiteaBot mentioned this pull request Apr 21, 2023
Merged
2 tasks
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 21, 2023
@harryzcy @GiteaBot
Fix access token issue on some public endpoints (go-gitea#24194)
25ff0d0 
- [x] Identify endpoints that should be public
- [x] Update integration tests

Fix go-gitea#24159
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 21, 2023
@harryzcy harryzcy deleted the issue-24159 branch April 21, 2023 15:41
silverwind pushed a commit that referenced this pull request Apr 21, 2023
@GiteaBot @harryzcy
Fix access token issue on some public endpoints (#24194) (#24259)
b00f7c3 
Backport #24194 by @harryzcy

- [x] Identify endpoints that should be public
- [x] Update integration tests

Fix #24159

Co-authored-by: harryzcy <harry@harryzheng.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

/api/v1/orgs has become an authenticated endpoint with 0.19
6 participants
@harryzcy @techknowlogick @lunny @wolfogre @delvh @GiteaBot