New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix calReleaseNumCommitsBehind (#24148) #24197
Merged
silverwind
merged 15 commits into
go-gitea:release/v1.19
from
oliverpool:backport-24148-v1.19
Apr 22, 2023
Merged
fix calReleaseNumCommitsBehind (#24148) #24197
silverwind
merged 15 commits into
go-gitea:release/v1.19
from
oliverpool:backport-24148-v1.19
Apr 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport go-gitea#24148 `repoCtx.CommitsCount` is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed). _contributed in the context of @forgejo_ --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
There were merge conflicts in the test cases, which I manually resolved (I could also drop them all if you prefer). |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 18, 2023
oliverpool
force-pushed
the
backport-24148-v1.19
branch
from
April 20, 2023 07:01
6531461
to
5666d08
Compare
silverwind
approved these changes
Apr 20, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 20, 2023
Gonna do a quick label test here |
yardenshoham
added
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 21, 2023
GiteaBot
removed
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 21, 2023
Ok done |
yardenshoham
added
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 22, 2023
GiteaBot
removed
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 22, 2023
yardenshoham
approved these changes
Apr 22, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 22, 2023
yardenshoham
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 22, 2023
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Apr 22, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24148
repoCtx.CommitsCount
is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed).contributed in the context of @forgejo