Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --font-weight-bold and set previous bold to 601 (#24307) #24331

Merged
merged 2 commits into from Apr 25, 2023
Merged

Add --font-weight-bold and set previous bold to 601 (#24307) #24331

merged 2 commits into from Apr 25, 2023

Conversation

wxiaoguang
Copy link
Contributor

Backport #24307

Fix #24305

According to MDN, "bold" starts from 700, some fonts do not provide "bolding" for weight 600

Manually backport, no CSS conflict.

@wxiaoguang
Add --font-weight-bold and set previous bold to 601 (go-gitea#24307)
406dc80 
Fix go-gitea#24305

According to MDN, "bold" starts from 700, some fonts do not provide
"bolding" for weight 600

https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
# Conflicts:
#	web_src/js/components/DashboardRepoList.vue
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2023
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 25, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2023
@wxiaoguang wxiaoguang added outdated/backport/v1.19 This PR should be backported to Gitea 1.19 and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2023
@GiteaBot GiteaBot removed the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
silverwind
silverwind approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good think you didn't include the bold removal in repo list, I think I will actually revert it 😆

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2023
@wxiaoguang
Copy link
Contributor Author

Just because .... there is a conflict, the Repo List has been refactored to Vue SFC in 1.20 🤣

@silverwind
Copy link
Member

#24337 for the revert for main branch.

@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Apr 25, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@silverwind silverwind enabled auto-merge (squash) April 25, 2023 23:12
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2023
@silverwind silverwind merged commit 5f82011 into go-gitea:release/v1.19 Apr 25, 2023
1 of 2 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@wxiaoguang wxiaoguang deleted the fix-font-bold branch April 26, 2023 00:56
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.19.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wxiaoguang @silverwind @lunny @yardenshoham @GiteaBot