Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea Actions add base_ref, head_ref, api_url, ref_type fields #24356

Merged
merged 4 commits into from Apr 27, 2023

Conversation

ChristopherHX
Copy link
Contributor

As discussed in https://gitea.com/gitea/act_runner/issues/147 github.base_ref is empty.
This change adds these fields to the server side context data.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2023
@wolfogre wolfogre added the topic/gitea-actions related to the actions of Gitea label Apr 27, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 27, 2023
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Apr 27, 2023

After this change dumping contextData in Gitea Actions

push

image

pull_request

image

api_url is still unavailable, this needs updates to gitea/act eventually just waiting for the next sync of the soft fork after 1 May 2023 is enough to make it visible

api_url in debugger
image

Was ref_name before this change already refs/pull/1/head? Based on the git.RefEndName yes, this is different in GitHub Actions as far I know.
We should probably strip the leading / from server_url to match GitHub Actions

@ChristopherHX ChristopherHX marked this pull request as ready for review April 27, 2023 09:02
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
@lunny lunny merged commit 6dfc0c8 into go-gitea:main Apr 27, 2023
2 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 28, 2023
* giteaofficial/main: (26 commits)
  Refactor docs (go-gitea#23752)
  Fix layouts of admin table / adapt repo / email test  (go-gitea#24370)
  Move secrets and runners settings to actions settings (go-gitea#24200)
  Gitea Actions add `base_ref`, `head_ref`, `api_url`, `ref_type` fields (go-gitea#24356)
  Fix auth check bug (go-gitea#24382)
  Display 'Unknown' when runner.version is empty (go-gitea#24378)
  Fix incorrect last online time in runner_edit.tmpl (go-gitea#24376)
  Refactor "route" related code, fix Safari cookie bug (go-gitea#24330)
  Add custom helm repo name generated from url (go-gitea#24363)
  Add API for gitignore templates (go-gitea#22783)
  Add eslint-plugin-regexp (go-gitea#24361)
  Support uploading file to empty repo by API (go-gitea#24357)
  [skip ci] Updated translations via Crowdin
  Require repo scope for PATs for private repos and basic authentication (go-gitea#24362)
  Alert error message if open dependencies are included in the issues that try to batch close (go-gitea#24329)
  Fix 404 error when leaving the last private org team (go-gitea#24322)
  Modify width of ui container, fine tune css for settings pages and org header (go-gitea#24315)
  Add .livemd as a markdown extension (go-gitea#22730)
  Display when a repo was archived (go-gitea#22664)
  Fix wrong error info in RepoRefForAPI (go-gitea#24344)
  ...
@ChristopherHX ChristopherHX deleted the add-context-data branch May 15, 2023 19:03
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants