Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable whitespace rendering on selection in Monaco #24444

Merged
merged 2 commits into from May 2, 2023
Merged

Enable whitespace rendering on selection in Monaco #24444

merged 2 commits into from May 2, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 30, 2023 •
edited

Remove the renderWhitespace override, so the default value of selection takes over and makes whitespace visible on selection.

Screenshot 2023-04-30 at 19 09 41

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 30, 2023
@silverwind silverwind mentioned this pull request Apr 30, 2023
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 2, 2023
@silverwind silverwind enabled auto-merge (squash) May 2, 2023 12:56
@silverwind silverwind merged commit 1f52560 into go-gitea:main May 2, 2023
3 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 2, 2023
@GiteaBot GiteaBot mentioned this pull request May 2, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request May 2, 2023
@silverwind @GiteaBot
Enable whitespace rendering on selection in Monaco (go-gitea#24444)
a2a1a4c 
Remove the
[renderWhitespace](https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IEditorOptions.html#renderWhitespace)
override, so the default value of `selection` takes over and makes
whitespace visible on selection.

<img width="128" alt="Screenshot 2023-04-30 at 19 09 41"
src="https://user-images.githubusercontent.com/115237/235366707-d598268d-03cc-4839-a195-c460bddae99b.png">

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 2, 2023
6543 pushed a commit that referenced this pull request May 2, 2023
@GiteaBot @silverwind
Enable whitespace rendering on selection in Monaco (#24444) (#24485)
c020bd5 
Backport #24444 by @silverwind

Remove the
[renderWhitespace](https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IEditorOptions.html#renderWhitespace)
override, so the default value of `selection` takes over and makes
whitespace visible on selection.

<img width="128" alt="Screenshot 2023-04-30 at 19 09 41"
src="https://user-images.githubusercontent.com/115237/235366707-d598268d-03cc-4839-a195-c460bddae99b.png">

Co-authored-by: silverwind <me@silverwind.io>
techknowlogick pushed a commit that referenced this pull request May 3, 2023
@GiteaBot @silverwind @techknowlogick
Enable whitespace rendering on selection in Monaco (#24444) (#24485)
73e70f3 
Backport #24444 by @silverwind

Remove the
[renderWhitespace](https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IEditorOptions.html#renderWhitespace)
override, so the default value of `selection` takes over and makes
whitespace visible on selection.

<img width="128" alt="Screenshot 2023-04-30 at 19 09 41"
src="https://user-images.githubusercontent.com/115237/235366707-d598268d-03cc-4839-a195-c460bddae99b.png">

Co-authored-by: silverwind <me@silverwind.io>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request May 3, 2023
@GiteaBot @silverwind
Enable whitespace rendering on selection in Monaco (go-gitea#24444) (g…
feeadb9 
…o-gitea#24485)

Backport go-gitea#24444 by @silverwind

Remove the
[renderWhitespace](https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IEditorOptions.html#renderWhitespace)
override, so the default value of `selection` takes over and makes
whitespace visible on selection.

<img width="128" alt="Screenshot 2023-04-30 at 19 09 41"
src="https://user-images.githubusercontent.com/115237/235366707-d598268d-03cc-4839-a195-c460bddae99b.png">

Co-authored-by: silverwind <me@silverwind.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 4, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
5c32bab 
* upstream/main: (65 commits)
  Changelog for 1.19.3 (go-gitea#24495) (go-gitea#24506)
  Use Actions for DB & E2E tests (go-gitea#24494)
  Fix intermittent CI failure in EmptyQueue (go-gitea#23753)
  Prevent a user with a different email from accepting the team invite (go-gitea#24491)
  Fix incorrect webhook time and use relative-time to display it (go-gitea#24477)
  Make Issue/PR/projects more compact, misc CSS tweaks (go-gitea#24459)
  Implement Cargo HTTP index (go-gitea#24452)
  Clean up polluted styles and remove dead CSS code (go-gitea#24497)
  Improve pull request merge box when pull request merged and branch deleted. (go-gitea#24397)
  Fix EasyMDE toolbar (go-gitea#24489)
  Enhance stylelint rule config, remove dead CSS (go-gitea#24472)
  Fix api error message if fork exists (go-gitea#24487)
  Add ntlm authentication support for mail (go-gitea#23811)
  Fix test delivery button in repo webhook settings page (go-gitea#24478)
  Add Debian package registry (go-gitea#24426)
  Enable whitespace rendering on selection in Monaco (go-gitea#24444)
  Replace `N/A` with `-` everywhere (go-gitea#24474)
  Fix invite display (go-gitea#24447)
  [skip ci] Updated translations via Crowdin
  replace PR docker dry run in drone with Actions (go-gitea#24475)
  ...

# Conflicts:
#	templates/base/footer_content.tmpl
Sh4kE added a commit to Sh4kE/k8s-projects that referenced this pull request May 7, 2023
@Sh4kE
Update gitea/gitea Docker tag to v1.19.3 (#178)
972b4b3 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.19.2-rootless` -> `1.19.3-rootless` |

---

### Release Notes

<details>
<summary>go-gitea/gitea</summary>

### [`v1.19.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#&#8203;1193-httpsgithubcomgo-giteagiteareleasestag1193---2023-05-03)

[Compare Source](go-gitea/gitea@v1.19.2...v1.19.3)

-   SECURITY
    -   Use golang 1.20.4 to fix CVE-2023-24539, CVE-2023-24540, and CVE-2023-29400
-   ENHANCEMENTS
    -   Enable whitespace rendering on selection in Monaco ([#&#8203;24444](go-gitea/gitea#24444)) ([#&#8203;24485](go-gitea/gitea#24485))
    -   Improve milestone filter on issues page ([#&#8203;22423](go-gitea/gitea#22423)) ([#&#8203;24440](go-gitea/gitea#24440))
-   BUGFIXES
    -   Fix api error message if fork exists ([#&#8203;24487](go-gitea/gitea#24487)) ([#&#8203;24493](go-gitea/gitea#24493))
    -   Fix user-cards format ([#&#8203;24428](go-gitea/gitea#24428)) ([#&#8203;24431](go-gitea/gitea#24431))
    -   Fix incorrect CurrentUser check for docker rootless ([#&#8203;24435](go-gitea/gitea#24435))
    -   Getting the tag list does not require being signed in ([#&#8203;24413](go-gitea/gitea#24413)) ([#&#8203;24416](go-gitea/gitea#24416))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4zIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Michael Wittig <michael.wittig@posteo.de>
Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/178
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @wxiaoguang @yardenshoham @GiteaBot